-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
Thanks for the PR! I'll take a look next week. |
Just to let you know that I didn't forget about this, but currently adapting our tools to the latest cairo-lang/starknet/compiler versions is the highest priority. |
Btw @tonypony220 I see some of the checkboxes in the PR description aren't checked. Do you plan to address them or do you think they are not necessary? |
c78f237
to
26412ce
Compare
Of course! I've done fresh rebase and run tests. |
…net into improve_logging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why didn't you check the linter checkbox?
8272d7b
to
1e5f404
Compare
Should I make all conversations resolved? |
@tonypony220 Hey, sorry for not having replied yet. Don't resolve the conversations, I plan to take a look at your new commits. It's just that I'm currently busy on other fronts. |
Just now I realized that this PR is still introducing a breaking change:
Do you have an opinion on that? I really wouldn't want to bump to 0.6.0 just because of this |
3838186
to
1dec324
Compare
Also a reminder to update the PR description. |
Were you planning to make more changes? I just ran your code and noticed the following issues:
|
ecfa1e7
to
f34769a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll assume you're done with new commits and approve&merge.
* Keeps the features of the PR but restores the log format * [skip ci]
Usage related changes
Closes #147
--verbose
arg--hide-server-logs
arg to hide access logging--hide-predeployed-contracts
arg to substitute--hide-predeployed-accounts
Development related changes
Checklist:
./scripts/format.sh
./scripts/lint.sh
./scripts/test.sh