This repository has been archived by the owner on Dec 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabijanC
suggested changes
May 16, 2023
17 tasks
Replaced inline test resources with compiled contract artifacts, formatted some files.
FabijanC
approved these changes
May 18, 2023
FabijanC
changed the title
Updated JsonRpc Api to v0.3.0-rc1
Update JsonRpc Api to v0.3.0-rc1
May 18, 2023
I can see that this was already merged but there are 7 failed tests, one is related to keys in get events.
|
Hi @bartekryba when you have a moment can you take a look at that, please? |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated JsonRpc api to support 0.3.0-rc1 spec. Closes #443, closes #401, addresses the same issue as #412 (consider closing)
Usage related changes
Development related changes
run_devnet_in_background
method, the flag--cairo-compiler-manifest
will be set by default if it wasn't explicitly set.Checklist:
./scripts/format.sh
./scripts/lint.sh
./scripts/test.sh