Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Update cairo_rs_py_patch to be compatible with cairo-lang 0.11 #439

Merged
merged 38 commits into from
Apr 13, 2023
Merged

Update cairo_rs_py_patch to be compatible with cairo-lang 0.11 #439

merged 38 commits into from
Apr 13, 2023

Conversation

fmoletta
Copy link
Contributor

@fmoletta fmoletta commented Apr 5, 2023 •
edited by FabijanC
Loading

This PR aims to re-introduce support for Rust VM after cairo-lang 0.11 changes. Resolves #424
Main changes:

  • Update cairo_rs_py dependency to version 0.2.0
  • Modify cairo_rs_py_patch.py to patch the new methods introduced in 0.11 which use the VM

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@fmoletta
Uncomment code + update class_hash_inner
4b5f9ef
@fmoletta
Update _run
354af88
@fmoletta
Add execute override
ead7f80
@fmoletta
Cleanup
20479a2
@fmoletta
Remove test asserting rust vm is unavailable
880d6a1
@fmoletta
Fix overriden fn name
e05f9f5
@fmoletta
Fixes
fbe05f7
@fmoletta
Fix path
025d68f
@fmoletta
Fixes to wrapper
77ce2eb
@fmoletta
Replace prepare_os_context with prepare_builtins
1dc7827
@fmoletta
Override _execute_version0_class
02f53d1
@fmoletta
misc fixes
89b435a
@fmoletta
Fix missing arg
d281f34
@fmoletta
Refactor run_from_entrypoint args handling
2bfac29
@fmoletta
Override _compute_compiled_class_hash_inner
dd6cd04
@fmoletta
Remove duplicated code
1c9d96d
@fmoletta
Fix flattened entry point args
e09954a
@fmoletta
Imports
4b9b6c2
@fmoletta
Override validate_builtins
d993d3a
@fmoletta
Avoid unsupported + operation + format
4962f86
@fmoletta
Override other post_run
a36bcea
@fmoletta
Temporarily disable verify_secure
d3798dc
@fmoletta
Add program_segment_size argument
8a13439
@fmoletta
Swich overrides
4bca61e
@fmoletta
format
31c0efc
@fmoletta
Undo change
bf1d756
@fmoletta
Replace full structure check for individual checks
a518ecf
@fmoletta
lint
661c663
@fmoletta
Undo change
360d2c1
@fmoletta
Add override for deprecated_class_hash
90663e5
@fmoletta fmoletta changed the title Update cairo_rs_py patch to be compatible with cairo-lang 0.11 Update cairo_rs_py_patch to be compatible with cairo-lang 0.11 Apr 5, 2023
@fmoletta fmoletta marked this pull request as ready for review April 5, 2023 18:19
@FabijanC FabijanC self-requested a review April 6, 2023 07:42
FabijanC
FabijanC suggested changes Apr 6, 2023
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a couple more places labeled with TMP: rust vm which are unaddressed:

  1. Two lines need to be uncommented in .circleci/config.yml.
  2. Update the docs by removing the temporarily suspended warning in page/docs/guide/run.md.

test/test_cairo_vm.py Show resolved Hide resolved
@fmoletta fmoletta requested a review from FabijanC April 10, 2023 16:07
FabijanC
FabijanC approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the contribution

@FabijanC FabijanC merged commit 5d9f66e into 0xSpaceShard:master Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reintroduce Rust VM support
2 participants
@fmoletta @FabijanC