Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Improve validation of block hash and transaction hash #409

Merged
merged 25 commits into from
Mar 1, 2023
Merged

Improve validation of block hash and transaction hash #409

merged 25 commits into from
Mar 1, 2023

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Feb 24, 2023 •
edited
Loading

Usage related changes

  • Improved validation for block hash in feeder_gateway for: get_block
  • Improved validation for transaction hash in feeder_gateway for: get_transaction, get_transaction_status, get_transaction_trace, get_transaction_receipt

Development related changes

  • New tests were added in test_endpoints.py and some were updated

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@mikiw mikiw marked this pull request as draft February 24, 2023 12:32
@mikiw mikiw linked an issue Feb 27, 2023 that may be closed by this pull request
Fix hex string validation #368
Closed
@mikiw mikiw changed the title Improve validation for get_block_by_hash Improve validation for get_block and get_transaction Feb 27, 2023
@mikiw mikiw marked this pull request as ready for review February 27, 2023 18:54
@mikiw mikiw requested a review from FabijanC February 27, 2023 18:54
FabijanC
FabijanC suggested changes Feb 28, 2023
View reviewed changes
starknet_devnet/blocks.py Show resolved Hide resolved
starknet_devnet/transactions.py Show resolved Hide resolved
starknet_devnet/blueprints/base.py Outdated Show resolved Hide resolved
starknet_devnet/util.py Show resolved Hide resolved
test/test_l1_l2_mock_messaging.py Show resolved Hide resolved
test/test_endpoints.py Outdated Show resolved Hide resolved
test/test_endpoints.py Outdated Show resolved Hide resolved
test/test_endpoints.py Outdated Show resolved Hide resolved
@FabijanC FabijanC changed the title Improve validation for get_block and get_transaction Improve validation of block hash and transaction hash Mar 1, 2023
@FabijanC FabijanC merged commit 746308b into master Mar 1, 2023
@FabijanC FabijanC deleted the hex-string-validation branch March 1, 2023 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix hex string validation
2 participants
@mikiw @FabijanC