Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow hide fields and types #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

allow hide fields and types #6

wants to merge 2 commits into from

Conversation

mac2000
Copy link

@mac2000 mac2000 commented Apr 27, 2020

According to #1 and my founding we gonna need to be able to hide fields exactly inside this transform not before (wont be able to delegate) not after (gateway wont work)

What have I done in this PR:

  1. Added hidden to both FederationFieldConfig and FederationObjectConfig
  2. Added null as possible return type to visitor - according to spec if we return null node will be removed
  3. Simple if statements to check whether current node is unwanted which return null

Test and readme also included

Hope to see it somewhere in near future in your library it will help us move further and connect everything into one beautiful graph without this hacky ways to remove unwanted fields

BR
Alex

@mac2000
Copy link
Author

mac2000 commented Nov 15, 2020

Accidentally did push packages upgrade, everything still working (tests and example server)

While upgrading added missed concurentlly package

If you want I can try to revert it and make separate PR just for versions upgrade, seems like it might solve many issues like #5

@VasiliKubarka
Copy link

@0xR if it fixes #5 then can we merge this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants