This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
[contracts] Refactor token implementations #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abandeali1
force-pushed
the
refactor/contracts/tokens
branch
2 times, most recently
from
4356b9b to
f343c3f
Compare
abandeali1
force-pushed
the
refactor/contracts/tokens
branch
3 times, most recently
from
7de76ae to
428c8a4
Compare
abandeali1
force-pushed
the
refactor/contracts/tokens
branch
2 times, most recently
from
76f6e1e to
649b16c
Compare
dekz
reviewed
Aug 15, 2018
| expect(log.args._to).to.be.equal(to); | ||
| expect(log.args._tokenId).to.be.bignumber.equal(tokenId); | ||
| }); | ||
| it('should transfer the token is spender is individually approved', async () => { |
| const newOwner = await token.ownerOf.callAsync(tokenId); | ||
| expect(newOwner).to.be.equal(to); | ||
| const transferLog = txReceipt.logs[0] as LogWithDecodedArgs<DummyERC721TokenTransferEventArgs>; | ||
| const receiverLog = txReceipt.logs[1] as LogWithDecodedArgs<InvalidERC721ReceiverTokenReceivedEventArgs>; |
There was a problem hiding this comment.
Should this be DummyERC721Receiver.... Guessing their Events are the same but since this is a valid test might make sense to use that type.
| /// @param _spender The address of the account able to transfer the tokens | ||
| /// @param _value The amount of wei to be approved for transfer | ||
| /// @return Whether the approval was successful or not | ||
| /// @return Always true if enough call has enough gas to complete execution |
There was a problem hiding this comment.
Always true if the call has enough gas to complete execution
| /// @dev `msg.sender` approves `_spender` to spend `_value` tokens | ||
| /// @param _spender The address of the account able to transfer the tokens | ||
| /// @param _value The amount of wei to be approved for transfer | ||
| /// @return Always true if enough call has enough gas to complete execution |
| external | ||
| { | ||
| require( | ||
| _value <= 10000000000000000000000, |
There was a problem hiding this comment.
maybe expose this so it's readable programatically (if it does change)
| _; | ||
| /// @notice Transfers the ownership of an NFT from one address to another address | ||
| /// @dev Throws unless `msg.sender` is the current owner, an authorized | ||
| /// perator, or the approved address for this NFT. Throws if `_from` is |
| /// Reverts if the given token ID already exists | ||
| /// @param _to Address of the beneficiary that will own the minted token | ||
| /// @param _tokenId ID of the token to be minted by the msg.sender | ||
| function _mint(address _to, uint256 _tokenId) |
There was a problem hiding this comment.
can we expose a public mintable function for testnets?
There was a problem hiding this comment.
We have DummyERC721Token. Maybe I should just drop the onlyOwner modifiers?
There was a problem hiding this comment.
Going to remove onlyOwner from mint but leave it on burn.
abandeali1
force-pushed
the
refactor/contracts/tokens
branch
from
5e9dd81 to
aa5a97e
Compare
…ate between events with same function signature
abandeali1
force-pushed
the
refactor/contracts/tokens
branch
from
aa5a97e to
87689f6
Compare
abandeali1
force-pushed
the
refactor/contracts/tokens
branch
from
87689f6 to
e35788e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing instructions
Types of changes
Checklist:
[WIP]if it is a work in progress.[sol-cov] Fixed bug.