This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
BUGFIX: don't remove maker/zrx order from cache twice #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to the Set docs Set.delete() just returns false and doesn't throw. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/delete |
|
@LogvinovLeon the issue is that you are trying to call |
fabioberger
approved these changes
Feb 1, 2018
|
This LGTM. Do we make this same mistake elsewhere? Would also be great if we could add a regression test for this. |
BMillman19
reviewed
Feb 1, 2018
| this._removeFromDependentOrderHashes(signedOrder.maker, zrxTokenAddress, orderHash); | ||
| this._removeFromDependentOrderHashes(signedOrder.maker, signedOrder.makerTokenAddress, orderHash); | ||
| if (zrxTokenAddress !== signedOrder.makerTokenAddress) { | ||
| this.removeFromDependentOrderHashes(signedOrder.maker, signedOrder.makerTokenAddress, orderHash); |
There was a problem hiding this comment.
theres an underscore missing here
There was a problem hiding this comment.
How did this compile 😕
There was a problem hiding this comment.
It didn't. But I changed that before publishing
This was referenced May 10, 2022
This was referenced Feb 2, 2024
Open
Open
Open
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing an order from the watcher cache, we call _removeFromDependentOrderHashes for both the makerTokenAddress and the ZRX token address for fees. The problem is when the makerTokenAddress is the ZRX token address and you call this line:
This fails and results in the rest of the script terminating.