Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Ignore test files and markdown files changes on publish #356

Merged
merged 3 commits into from
Feb 5, 2018

Conversation

LogvinovLeon
Copy link
Contributor

Description

This PR aggs lerna ignore config to ignore non-source changes when publishing new versions.

Motivation and Context

This removes some redundant publishes.

How Has This Been Tested?

lerna updated

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Change requires a change to the documentation.
  • Added tests to cover my changes.

@coveralls
Copy link

coveralls commented Jan 31, 2018

Coverage Status

Coverage decreased (-0.02%) to 90.141% when pulling 0c6cbb6 on lerna-ignore into 6682abf on development.

@BMillman19
Copy link
Contributor

BMillman19 commented Jan 31, 2018

I think we may want to ignore the /scripts folder as well, and /lib ?

Copy link
Contributor

@fabioberger fabioberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we've added a couple more files to these, LGTM.

lerna.json Outdated
@@ -2,6 +2,11 @@
"lerna": "2.5.1",
"packages": ["packages/*"],
"version": "independent",
"commands": {
"publish": {
"ignore": ["test/**/*", "*.md", "scripts", "lib"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about ignoring README, tslint.json, tsconfig.tson changes?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants