This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Modify lint rules to enforce underscore for protected members #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BMillman19
requested review from
dekz,
fabioberger,
LogvinovLeon and
abandeali1
LogvinovLeon
approved these changes
Jan 31, 2018
…ected-members * development: Updated contract generation in 0x to new abi-gen CLI Removed deprecated CLI options Added PR # to the changelog of abi-gen Added CLI options for explicit specifying location of partials and main template
BMillman19
deleted the
feature/tslint-config/underscore-protected-members
branch
This was referenced May 10, 2022
This was referenced Feb 2, 2024
Open
Open
Open
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified custom 'underscore-privates' rule, changing it to 'underscore-private-and-protected' requiring underscores to be prepended to both private and protected variable names
Motivation and Context
Fixes inconsistent usage of an underscore prefix for protected members
How Has This Been Tested?
lerna run testTypes of changes
Checklist: