This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Streamline SwapQuoter and remove instant-only functions #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianny
changed the base branch from
asset-swapper-v1-refactor
to
refactor-asset-swapper-v1
xianny
force-pushed
the
refactor/AS-fewer-functions
branch
from
30320ce to
4d2264c
Compare
alexkroeger
force-pushed
the
refactor-asset-swapper-v1
branch
from
b1e2f44 to
1adb56f
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed because no activity occured in 7 days after being marked as stale. If it's still relevant - feel free to reopen. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MarketOperationas a param instead of having separate functions for buy/sellTesting instructions
Types of changes
Checklist:
[WIP]if necessary.