Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Expose fills object in asset-swapper quote orders #2583

Merged
merged 5 commits into from
May 20, 2020

Conversation

fragosti
Copy link
Contributor

@fragosti fragosti commented May 20, 2020

Description

In order to calculate estimatedGasTokenRefund in API we need more information from asset-swapper.

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@fragosti fragosti changed the title Expose fills in asset-swapper quote Expose fills object in asset-swapper quote orders May 20, 2020
Copy link
Contributor

@dorothy-zbornak dorothy-zbornak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ᕦ◉▿◉ᕤ

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 79.588% when pulling f694072 on feat/estimated-gas-token-refund into d9e13d6 on development.

@fragosti fragosti merged commit b23f1eb into development May 20, 2020
@fragosti fragosti deleted the feat/estimated-gas-token-refund branch May 20, 2020 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants