This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
[asset-swapper] Forwarder market sell throw when amount not sold #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekz
requested review from
abandeali1,
BMillman19,
dave4506,
fragosti and
hysz
as code owners
dekz
changed the base branch from
development
to
feat/forwarder/market-sell-amount
dorothy-zbornak
approved these changes
Mar 30, 2020
dekz
added a commit
that referenced
this pull request
Mar 31, 2020
* Forwarder Market sell specified amount or throw * Address feedback comments * Break if we have only protocol fee remaining * Lint * Update deployed addresses * Updated artifacts and wrappers * [asset-swapper] Forwarder throws on market sell if amount not sold (#2534)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#2521