This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorothy-zbornak
force-pushed
the
feat/sol-compiler/support-0.6
branch
5 times, most recently
from
March 30, 2020 20:20
e322fab
to
a9de941
Compare
Closed
jalextowle
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! I have a few questions and comments, but it looks ready to merge once those are addressed.
hysz
reviewed
Mar 31, 2020
hysz
reviewed
Mar 31, 2020
hysz
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (~‾▿‾)~
…ey're within modules. `@0x/sol-compiler`: Makea Add v0.6 solidity test.
dorothy-zbornak
force-pushed
the
feat/sol-compiler/support-0.6
branch
from
April 1, 2020 17:42
a9de941
to
9f5f578
Compare
dorothy-zbornak
force-pushed
the
feat/sol-compiler/support-0.6
branch
from
April 1, 2020 18:30
9f5f578
to
b9a68c0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #2528
This adds solidity 0.6 support to
sol-compiler
. I've also done some decent-sized refactors to (hopefully) make compatibility with new versions/features easier to integrate, and to tidy up the code. There are some other small changes listed below.Parallelization
I rewrote a bunch of the code to be parallelized, to speed up build times.
Artifact Changes
settings
object is now normalized to{VERSION}+commit.{COMMIT_HASH}
. Previously it could take on many forms, depending on where your compiler comes from (docker, npm, direct path).version
in theirsettings
object. This makes automated verification a bit easier because we don't have to look up the solidity version used from the output artifacts as well.Testing instructions
Types of changes
Checklist:
[WIP]
if necessary.