Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Fix DydxBridge addresses. #2529

Conversation

dorothy-zbornak
Copy link
Contributor

@dorothy-zbornak dorothy-zbornak commented Mar 26, 2020

Description

The mainnet and kovan DydxBridge addresses were wrong.

I actually couldn't find the kovan deployment so I just redeployed that one.

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

`@0x/contract-addresses`: Lowercase GodsUnchained/broker addresses.
@dorothy-zbornak dorothy-zbornak force-pushed the fix/contract-addresses/fix-dydx-bridge-mainnet-address branch from b468134 to 17d81bf Compare March 26, 2020 02:40
@dorothy-zbornak dorothy-zbornak changed the title Fix DydxBridge mainnet address. Fix DydxBridge addresses. Mar 26, 2020
@dorothy-zbornak dorothy-zbornak marked this pull request as ready for review March 26, 2020 02:42
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 79.688% when pulling 17d81bf on fix/contract-addresses/fix-dydx-bridge-mainnet-address into 568e9be on development.

@dorothy-zbornak dorothy-zbornak merged commit 0fdfb03 into development Mar 26, 2020
@dorothy-zbornak dorothy-zbornak deleted the fix/contract-addresses/fix-dydx-bridge-mainnet-address branch March 26, 2020 03:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants