Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Rename ERC20BridgeTransfer event args #2524

Conversation

dorothy-zbornak
Copy link
Contributor

The old ones were pretty ambiguous. So instead of fromToken an toToken, we have inputToken and outputToken, respectively.

Description

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@dorothy-zbornak dorothy-zbornak force-pushed the feat/erc20-bridge/less-ambiguous-transfer-event-args branch from f925458 to ce96e35 Compare March 14, 2020 01:00
@dorothy-zbornak dorothy-zbornak marked this pull request as ready for review March 14, 2020 01:01
Copy link
Contributor

@hysz hysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! (~‾▿‾)~

@coveralls
Copy link

coveralls commented Mar 14, 2020

Coverage Status

Coverage decreased (-0.03%) to 79.613% when pulling ce96e35 on feat/erc20-bridge/less-ambiguous-transfer-event-args into b7fb539 on development.

@dorothy-zbornak dorothy-zbornak merged commit 7a68260 into development Mar 14, 2020
@dorothy-zbornak dorothy-zbornak deleted the feat/erc20-bridge/less-ambiguous-transfer-event-args branch March 14, 2020 03:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants