This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
@0x/contracts-erc20-bridge-sampler: LiquidityProviderRegistry
#2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodlezoup
force-pushed
the
feature/erc20-bridge-sampler/liquidity-provider-registry
branch
from
d70ac86 to
4bc5106
Compare
moodlezoup
changed the title
@0x/contracts-erc20-bridge-sampler: LiquidityProviderRegistry
PirosB3
reviewed
Feb 27, 2020
| takerToken, | ||
| makerToken | ||
| ); | ||
|
|
There was a problem hiding this comment.
if a liquidity pool is not found, we should return an array of 0s
PirosB3
reviewed
Feb 27, 2020
| @@ -435,14 +436,14 @@ contract ERC20BridgeSampler is | |||
| } | |||
|
|
|||
| /// @dev Sample sell quotes from an arbitrary on-chain liquidity provider. | |||
| /// @param providerAddress Address of the liquidity provider contract. | |||
| /// @param registryAddress Address of the liquidity provider registry contract. | |||
| /// @param takerToken Address of the taker token (what to sell). | |||
| /// @param makerToken Address of the maker token (what to buy). | |||
| /// @param takerTokenAmounts Taker token sell amount for each sample. | |||
| /// @return makerTokenAmounts Maker amounts bought at each taker token | |||
| /// amount. | |||
| function sampleSellsFromLiquidityProvider( | |||
There was a problem hiding this comment.
As discussed, this should be sample(Sells|Buys)FromLiquidityProviderRegistry()
moodlezoup
force-pushed
the
feature/erc20-bridge-sampler/liquidity-provider-registry
branch
from
99d94b3 to
52bd73a
Compare
moodlezoup
force-pushed
the
feature/erc20-bridge-sampler/liquidity-provider-registry
branch
from
52bd73a to
a47c031
Compare
PirosB3
reviewed
Feb 27, 2020
| ) | ||
| public | ||
| view | ||
| returns (address providerAddress) |
There was a problem hiding this comment.
by default, is providerAddress set to address(0)?
dorothy-zbornak
approved these changes
Feb 27, 2020
PirosB3
approved these changes
Feb 27, 2020
PirosB3
deleted the
feature/erc20-bridge-sampler/liquidity-provider-registry
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the way the ERC20BridgeSampler samples from generic liquidity providers to route through a registry. This allows the owner of the registry to swap out the underlying liquidity providers without interruption for 0x API
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.