This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
[FIX] Instant + Asset-swapper support for ERC721 #2491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave4506
changed the title
dave4506
changed the title
fragosti
reviewed
Feb 24, 2020
fragosti
approved these changes
Feb 28, 2020
dave4506
force-pushed
the
fix/instant/support-erc721
branch
from
55e6a67 to
8afb044
Compare
|
If you can deploying this guy today would be 🔥 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Patches
@0x/asset-swapperto support ERC721 assets (broken due to our new smart order routing logic).Testing instructions
Types of changes
Checklist:
[WIP]if necessary.