Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Broker-related updates to contract-artifacts, contract-wrappers, contract-addresses #2469

Merged
merged 8 commits into from
Feb 11, 2020
Merged

Broker-related updates to contract-artifacts, contract-wrappers, contract-addresses #2469

merged 8 commits into from
Feb 11, 2020

Conversation

moodlezoup
Copy link
Contributor

@moodlezoup moodlezoup commented Feb 4, 2020 •
edited
Loading

Description

Adds Broker and GodsUnchainedValidator to contract-artifacts, contract-wrappers, and contract-addresses (they have been deployed to Ropsten and mainnet). Removes references to DutchAuction and OrderValidator in those packages as well.
I also redeployed the Forwarder to testnets since it looks like we haven't done so since the v2 backwards compatibility PR

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@buildsize
Copy link

buildsize bot commented Feb 4, 2020 •
edited
Loading

File name Previous Size New Size Change
init.py 60.43 KB 60.43 KB 0 bytes (0%)
abi_gen_dummy.ts 85.45 KB [deleted]
lib_dummy.ts 7.13 KB [deleted]
test_lib_dummy.ts 10.56 KB [deleted]
environment.pickle 1.72 MB 1.72 MB 0 bytes (0%)
index.doctree 436.61 KB 436.61 KB 0 bytes (0%)
.buildinfo 230 bytes 230 bytes 0 bytes (0%)
genindex.html 31.42 KB 31.42 KB 0 bytes (0%)
index.html 4.69 KB 4.69 KB 0 bytes (0%)
objects.inv 1 KB 1 KB 0 bytes (0%)
py-modindex.html 3.07 KB 3.07 KB 0 bytes (0%)
search.html 2.84 KB 2.84 KB 0 bytes (0%)
searchindex.js 11.97 KB 11.97 KB 0 bytes (0%)
index.rst.txt 2.22 KB 2.22 KB 0 bytes (0%)
alabaster.css 10.92 KB 10.92 KB 0 bytes (0%)
basic.css 11.97 KB 11.97 KB 0 bytes (0%)
custom.css 42 bytes 42 bytes 0 bytes (0%)
doctools.js 9.05 KB 9.05 KB 0 bytes (0%)
documentation_options.js 324 bytes 324 bytes 0 bytes (0%)
file.png 286 bytes 286 bytes 0 bytes (0%)
jquery-[version].js 273.79 KB 273.79 KB 0 bytes (0%)
jquery.js 86.08 KB 86.08 KB 0 bytes (0%)
language_data.js 10.59 KB 10.59 KB 0 bytes (0%)
minus.png 90 bytes 90 bytes 0 bytes (0%)
plus.png 90 bytes 90 bytes 0 bytes (0%)
pygments.css 4.69 KB 4.69 KB 0 bytes (0%)
searchtools.js 15.65 KB 15.65 KB 0 bytes (0%)
underscore-[version].js 34.34 KB 34.34 KB 0 bytes (0%)
underscore.js 11.86 KB 11.86 KB 0 bytes (0%)
contract_addresses.html 16.8 KB 16.03 KB -796 bytes (5%)
contract_artifacts.html 8.24 KB 8.24 KB 0 bytes (0%)
json_schemas.html 12.56 KB 12.56 KB 0 bytes (0%)
order_utils.html 47.16 KB 47.16 KB 0 bytes (0%)
erc20_token.html 93.56 KB 93.56 KB 0 bytes (0%)
exchange.html 730.72 KB 730.72 KB 0 bytes (0%)
tx_params.html 9.41 KB 9.41 KB 0 bytes (0%)
local_message_signer.html 15.08 KB 15.08 KB 0 bytes (0%)
asset_data_utils.html 22.66 KB 22.66 KB 0 bytes (0%)
asset_proxy_owner.html 337.39 KB 337.39 KB 0 bytes (0%)
coordinator.html 128.72 KB 128.72 KB 0 bytes (0%)
coordinator_registry.html 39.59 KB 39.59 KB 0 bytes (0%)
dutch_auction.html 66.13 KB 66.13 KB 0 bytes (0%)
erc20_proxy.html 111.83 KB 111.83 KB 0 bytes (0%)
erc721_proxy.html 111.95 KB 111.95 KB 0 bytes (0%)
erc721_token.html 150.2 KB 150.2 KB 0 bytes (0%)
forwarder.html 130.08 KB 130.08 KB 0 bytes (0%)
i_asset_proxy.html 40.18 KB 40.18 KB 0 bytes (0%)
i_validator.html 27.06 KB 27.06 KB 0 bytes (0%)
i_wallet.html 24.9 KB 24.9 KB 0 bytes (0%)
multi_asset_proxy.html 146.81 KB 146.81 KB 0 bytes (0%)
order_validator.html 107.69 KB 107.69 KB 0 bytes (0%)
weth9.html 133.39 KB 133.39 KB 0 bytes (0%)
zrx_token.html 107.61 KB 107.61 KB 0 bytes (0%)
dev_utils.html 593.43 KB 593.43 KB 0 bytes (0%)
types.html 8.54 KB 8.54 KB 0 bytes (0%)
erc1155_mintable.html 276.51 KB 276.51 KB 0 bytes (0%)
erc1155_proxy.html 133.15 KB 133.15 KB 0 bytes (0%)
static_call_proxy.html 34.04 KB 34.04 KB 0 bytes (0%)
relayer_api.html 113.37 KB 113.37 KB 0 bytes (0%)
relayer_api_asset_data_pairs_response_schema.html 13.86 KB 13.86 KB 0 bytes (0%)
relayer_api_asset_data_trade_info_schema.html 23.09 KB 23.09 KB 0 bytes (0%)
relayer_api_error_response_schema.html 19.74 KB 19.74 KB 0 bytes (0%)
relayer_api_error_response_schema_validation_errors.html 19.92 KB 19.92 KB 0 bytes (0%)
relayer_api_fee_recipients_response_schema.html 13.83 KB 13.83 KB 0 bytes (0%)
relayer_api_order_config_payload_schema.html 39.52 KB 39.52 KB 0 bytes (0%)
relayer_api_order_config_response_schema.html 25.23 KB 25.23 KB 0 bytes (0%)
relayer_api_order_schema.html 15.88 KB 15.88 KB 0 bytes (0%)
relayer_api_orderbook_response_schema.html 16.2 KB 16.2 KB 0 bytes (0%)
relayer_api_orders_channel_subscribe_payload_schema.html 35.06 KB 35.06 KB 0 bytes (0%)
relayer_api_orders_channel_subscribe_schema.html 22.98 KB 22.98 KB 0 bytes (0%)
relayer_api_orders_channel_update_schema.html 22.83 KB 22.83 KB 0 bytes (0%)
relayer_api_orders_response_schema.html 13.75 KB 13.75 KB 0 bytes (0%)
signed_order_schema.html 14.36 KB 14.36 KB 0 bytes (0%)

@coveralls
Copy link

coveralls commented Feb 5, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 79.713% when pulling fef7f05 on feature/broker/deployments into 5754c11 on development.

@moodlezoup moodlezoup force-pushed the feature/broker/deployments branch from ef4293e to e2b8307 Compare February 5, 2020 00:10
@moodlezoup moodlezoup changed the title Add Broker and GodsUnchainedValidator to contract-artifacts Broker-related updates to contract-artifacts, contract-wrappers, contract-addresses Feb 5, 2020
@moodlezoup moodlezoup marked this pull request as ready for review February 5, 2020 00:21
@moodlezoup moodlezoup force-pushed the feature/broker/deployments branch from e2b8307 to cca02b6 Compare February 5, 2020 00:42
@moodlezoup moodlezoup requested a review from feuGeneA as a code owner February 5, 2020 00:42
@moodlezoup moodlezoup force-pushed the feature/broker/deployments branch from cca02b6 to a82ccac Compare February 5, 2020 01:08
hysz
hysz approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@hysz hysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@moodlezoup moodlezoup force-pushed the feature/broker/deployments branch from a82ccac to 2727343 Compare February 6, 2020 18:28
@dorothy-zbornak dorothy-zbornak self-assigned this Feb 6, 2020
dorothy-zbornak
dorothy-zbornak approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@dorothy-zbornak dorothy-zbornak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👂 👁️ 👃 👁️ 👂
👍      👄       👍

packages/migrations/src/migration.ts
Comment on lines -277 to -291
orderValidator: constants.NULL_ADDRESS,
dutchAuction: constants.NULL_ADDRESS,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚰️

@moodlezoup moodlezoup force-pushed the feature/broker/deployments branch 2 times, most recently from 1904f11 to 942cfd7 Compare February 11, 2020 01:04
@moodlezoup moodlezoup force-pushed the feature/broker/deployments branch from 82e6016 to f44eb4e Compare February 11, 2020 01:11
@moodlezoup moodlezoup force-pushed the feature/broker/deployments branch from 11b6cf9 to fef7f05 Compare February 11, 2020 01:38
@moodlezoup moodlezoup merged commit 1b83ebd into development Feb 11, 2020
@moodlezoup moodlezoup deleted the feature/broker/deployments branch February 11, 2020 02:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dorothy-zbornak dorothy-zbornak dorothy-zbornak approved these changes

@hysz hysz hysz approved these changes

@abandeali1 abandeali1 Awaiting requested review from abandeali1 abandeali1 is a code owner

@feuGeneA feuGeneA Awaiting requested review from feuGeneA

Assignees

@dorothy-zbornak dorothy-zbornak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moodlezoup @coveralls @hysz @dorothy-zbornak