This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveklebanoff
commented
Nov 11, 2019
steveklebanoff
commented
Nov 11, 2019
@@ -59,7 +59,7 @@ | |||
"@0x/tslint-config": "^3.1.0-beta.1", | |||
"@types/bip39": "^2.4.0", | |||
"@types/bn.js": "^4.11.0", | |||
"@types/ethereumjs-tx": "^1.0.0", | |||
"@types/ethereumjs-tx": "^1.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed to do this to get the gasPrice
and gasLimit
attributes
|
dekz
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM tests are failing for a weird reason though.
fabioberger
approved these changes
Nov 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a DebugSubprovider. Useful for investigating RPC calls.
Inspired from the situation in which transactions were not getting generated correctly, and it took a long time to recognize that a subprovider was generating incorrect nonces.
Testing instructions
Add a DebugSubprovider before the final subprovider (i.e. RPCSubprovider) and watch statements be logged to
console.debug
Types of changes
New feature
Checklist:
[WIP]
if necessary.