This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Unit tests for MixinCumulativeRewards #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hysz
force-pushed
the
tests/3.0/StakingMixinCumulativeRewardsUnitTEsts
branch
from
e1f0708 to
4881ef9
Compare
jalextowle
approved these changes
Nov 5, 2019
| expect(reward).to.bignumber.equal(ZERO); | ||
| }); | ||
|
|
||
| it('Should revert if start is greater than the end of the interval', async () => { |
There was a problem hiding this comment.
Despite the fact that this should never happen, I think it could make sense to test for the case when we don't have the right "endpoints." Basically, when we are missing the cumulative reward values that we need to calculate rewards.
There was a problem hiding this comment.
This is handled by Should successfully compute reward are no cumulative reward entries - in this case the default CR is used.
hysz
force-pushed
the
tests/3.0/StakingMixinCumulativeRewardsUnitTEsts
branch
from
4881ef9 to
2d0ad6f
Compare
moodlezoup
approved these changes
Nov 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unit tests for MixinCumulativeRewards in the Staking contracts package.
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.