This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Unit tests for MixinScheduler #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodlezoup
approved these changes
Nov 5, 2019
| // (i) Set `epochDurationInSeconds` to a constant value of 1, and | ||
| // (ii) Rearrange the eqn above to get: | ||
| // `currentEpochStartTimeInSeconds = epochEndTimeDelta + block.timestamp - epochDurationInSeconds` | ||
| epochDurationInSeconds = 1; |
There was a problem hiding this comment.
why do we set this to 1? can we use a more realistic value?
There was a problem hiding this comment.
The value just needs to be non-zero. Allows us to verify that the endTime is accounting for both currentEpochStartTimeInSeconds and epochDurationInSeconds.
Comment on lines
+109
to
+117
| // Mine the block that this tx would've been in. | ||
| await env.web3Wrapper.mineBlockAsync(); | ||
| const blockNumber = await env.web3Wrapper.getBlockNumberAsync(); | ||
| const blockTimestampAsNumber = await env.web3Wrapper.getBlockTimestampAsync(blockNumber); | ||
| const blockTimestamp = new BigNumber(blockTimestampAsNumber); | ||
| const epochEndTime = blockTimestamp.plus(epochEndTimeDelta); | ||
| return expect(tx).to.revertWith( | ||
| new StakingRevertErrors.BlockTimestampTooLowError(epochEndTime, blockTimestamp), | ||
| ); |
Comment on lines
84
to
85
| expect(currentEpoch).to.bignumber.equal(testLog.oldEpoch.plus(1)); | ||
| expect(currentEpochStartTimeInSeconds).to.bignumber.equal(testLog.blockTimestamp); |
There was a problem hiding this comment.
optional nit: use verifyEventsFromLogs for these events
jalextowle
reviewed
Nov 5, 2019
| } catch (e) {} | ||
|
|
||
| // Mine the block that this tx would've been in. | ||
| await env.web3Wrapper.mineBlockAsync(); |
There was a problem hiding this comment.
This is a pretty cool pattern. Might make sense to make a function and put in test-utils, but optional for this PR.
There was a problem hiding this comment.
🙏 - although it's such an edge case idk if it would be worth abstracting as-is.
| expect(currentEpochStartTimeInSeconds).to.bignumber.equal(testLog.blockTimestamp); | ||
| }); | ||
|
|
||
| it('Should succeed if epoch end time is equal to block timestamp', async () => { |
jalextowle
approved these changes
Nov 5, 2019
hysz
force-pushed
the
tests/3.0/MixinSchedulerUnitTests
branch
from
87b8cc8 to
9b2231e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes unit tests for
MixinSchedulerin the Staking Contracts.Testing instructions
Types of changes
Checklist:
[WIP]if necessary.