Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Rename withdrawTo to bridgeTransferFrom #2283

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Rename withdrawTo to bridgeTransferFrom #2283

merged 1 commit into from
Oct 23, 2019

Conversation

abandeali1
Copy link
Member

@abandeali1 abandeali1 commented Oct 23, 2019 •
edited by dorothy-zbornak
Loading

Description

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

Affects 0xProject/ZEIPs/issues/47

@abandeali1 abandeali1 requested a review from hysz as a code owner October 23, 2019 05:52
@coveralls
Copy link

coveralls commented Oct 23, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 75.286% when pulling 281658b on fix/3.0/rename-bridge-withdraw-to into f192648 on 3.0.

hysz
hysz approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@hysz hysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this 👍

@dorothy-zbornak dorothy-zbornak self-assigned this Oct 23, 2019
dorothy-zbornak
dorothy-zbornak approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@dorothy-zbornak dorothy-zbornak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better.
I think we're ultimately going to need an ayahuasca spirit journey to find the perfect name for this function.

@abandeali1 abandeali1 force-pushed the fix/3.0/rename-bridge-withdraw-to branch from 20ae85a to 281658b Compare October 23, 2019 16:42
@abandeali1 abandeali1 merged commit 0671520 into 3.0 Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dorothy-zbornak dorothy-zbornak dorothy-zbornak approved these changes

@hysz hysz hysz approved these changes

Assignees

@dorothy-zbornak dorothy-zbornak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abandeali1 @coveralls @hysz @dorothy-zbornak