This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Remove assertion that protocol fee != zero #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abandeali1
approved these changes
Oct 22, 2019
| @@ -144,14 +144,13 @@ export class InvalidParamValueError extends RevertError { | |||
|
|
|||
| export class InvalidProtocolFeePaymentError extends RevertError { | |||
| constructor( | |||
| errorCode?: ProtocolFeePaymentErrorCodes, | |||
There was a problem hiding this comment.
We can remove the ProtocolFeePaymentErrorCodes enum too right?
hysz
force-pushed
the
fix/3.0/removeProtocolFeeZeroAssertion
branch
from
e3bfbbe to
c44e16a
Compare
jalextowle
approved these changes
Oct 22, 2019
| @@ -29,11 +29,6 @@ library LibStakingRichErrors { | |||
| CanOnlyDecreaseOperatorShare | |||
| } | |||
|
|
|||
| enum ProtocolFeePaymentErrorCodes { | |||
hysz
changed the base branch from
cleanup/staking/finalizationDataStructures
to
3.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is the responsibility of the exchange - not the staking contract - to determine if the protocol fee paid is correct.
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.