This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Fix LibFixedMath arithmetic overflows #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses arithmetic overflows in the staking contracts'
LibFixedMathlibrary.Checks were added to:
sub()_add()_mul()_div()The preliminary audit did uncover the majority of these overflows but the limits in the report were wrong, and I found some other edge cases. So the checks differ from those suggested the report.
I also removed the fixed math
BinOpErrorCodes.SubtractionUnderflowerror code, since I didn't feel the distinction is all that useful in practice since it's just implemented as a negated addition.Fixes 0xProject/protocol-development-sprint#4
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.