This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Add SafeMath to Multisig #2254
Merged
Add SafeMath to Multisig #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodlezoup
approved these changes
Oct 9, 2019
contracts/multisig/contracts/src/MultiSigWalletWithTimeLock.sol
Outdated
Show resolved
Hide resolved
jalextowle
commented
Oct 9, 2019
contracts/multisig/contracts/src/MultiSigWalletWithTimeLock.sol
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the addition
confirmationTimes[transactionId] + secondsTimeLockedcould have overflown in the modifierpastTimeLockinMultiSigWalletWithTimeLock. This pull request replaces this addition with a call to_safeAddinSafeMath.Testing instructions
Types of changes
Checklist:
[WIP]if necessary.