This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Wrap payProtocolFee with rich revert + reduce codesize
#2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abandeali1
force-pushed
the
feat/3.0/catch-pay-protocol-fee-err
branch
from
50414c0 to
b2b24c7
Compare
…hash to be passed into EIP1271 compliant contract
abandeali1
force-pushed
the
feat/3.0/catch-pay-protocol-fee-err
branch
from
b2b24c7 to
90ac5ec
Compare
jalextowle
approved these changes
Sep 4, 2019
Update comment Co-Authored-By: James Towle <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.Affects 0xProject/ZEIPs/issues/33