This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use local EVM for pure functions #2108
Use local EVM for pure functions #2108
Changes from 5 commits
2f5f9c6
e0a4c82
1c5de77
62d7cd5
5ead509
456669f
c53002a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still worried about this hack. Does this mean anyone using
0x.js
in a webpack project will need to do this too to get it to work? If so, please add browser-specific instructions to the README explaining the need for this step.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a test project importing 0x.js and tried bundling with webpack. Sadly yes and there doesn't seem to be any workaround as long as we are using
ethereumjs-vm
as a dependency. I'll add instructions to the README.