Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Remove solc-bin from npm publish #2044

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Conversation

dekz
Copy link
Member

@dekz dekz commented Aug 8, 2019

3.1.11 was published with
https://unpkg.com/browse/@0x/[email protected]/lib/solc_bin/

Description

Prevent multiple versions of sol compiler being published in the package. These are downloaded on demand.

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@dekz dekz added the bug 🪲 label Aug 8, 2019
@buildsize
Copy link

buildsize bot commented Aug 8, 2019

File name Previous Size New Size Change
init.py 141.35 KB 141.35 KB 0 bytes (0%)
abi_gen_dummy.ts 144.09 KB [deleted]
lib_dummy.ts 4.74 KB [deleted]
test_lib_dummy.ts 12.61 KB [deleted]
environment.pickle 1.56 MB 1.56 MB 0 bytes (0%)
index.doctree 189.53 KB 189.53 KB 0 bytes (0%)
.buildinfo 230 bytes 230 bytes 0 bytes (0%)
genindex.html 5.6 KB 5.6 KB 0 bytes (0%)
index.html 2.52 KB 2.52 KB 0 bytes (0%)
objects.inv 375 bytes 375 bytes 0 bytes (0%)
py-modindex.html 3.07 KB 3.07 KB 0 bytes (0%)
search.html 2.81 KB 2.81 KB 0 bytes (0%)
searchindex.js 5.83 KB 5.83 KB 0 bytes (0%)
index.rst.txt 415 bytes 415 bytes 0 bytes (0%)
alabaster.css 10.92 KB 10.92 KB 0 bytes (0%)
basic.css 11.83 KB 11.83 KB 0 bytes (0%)
custom.css 42 bytes 42 bytes 0 bytes (0%)
doctools.js 9.05 KB 9.05 KB 0 bytes (0%)
documentation_options.js 303 bytes 303 bytes 0 bytes (0%)
file.png 286 bytes 286 bytes 0 bytes (0%)
jquery-[version].js 261.76 KB 261.76 KB 0 bytes (0%)
jquery.js 84.63 KB 84.63 KB 0 bytes (0%)
language_data.js 10.59 KB 10.59 KB 0 bytes (0%)
minus.png 90 bytes 90 bytes 0 bytes (0%)
plus.png 90 bytes 90 bytes 0 bytes (0%)
pygments.css 4.69 KB 4.69 KB 0 bytes (0%)
searchtools.js 15.61 KB 15.61 KB 0 bytes (0%)
underscore-[version].js 34.34 KB 34.34 KB 0 bytes (0%)
underscore.js 11.86 KB 11.86 KB 0 bytes (0%)
contract_addresses.html 17.89 KB 17.89 KB 0 bytes (0%)
contract_artifacts.html 7.94 KB 7.94 KB 0 bytes (0%)
_bootstrap.html 142.73 KB 142.73 KB 0 bytes (0%)
json_schemas.html 12.43 KB 12.43 KB 0 bytes (0%)
order_utils.html 44.87 KB 44.87 KB 0 bytes (0%)
erc20_token.html 80.16 KB 80.16 KB 0 bytes (0%)
exchange.html 458.92 KB 458.92 KB 0 bytes (0%)
tx_params.html 8.83 KB 8.83 KB 0 bytes (0%)
local_message_signer.html 15.07 KB 15.07 KB 0 bytes (0%)
asset_data_utils.html 22.65 KB 22.65 KB 0 bytes (0%)
default_api.html 118.49 KB 118.49 KB 0 bytes (0%)
globals.html 13.15 KB [deleted]
asset_proxy_owner.assetproxyownercontract.html 419.2 KB [deleted]
coordinator.coordinatorcontract.html 153.51 KB [deleted]
coordinator_registry.coordinatorregistrycontract.html 95.28 KB [deleted]
dummy_erc20_token.dummyerc20tokencontract.html 250.08 KB [deleted]
dummy_erc721_token.dummyerc721tokencontract.html 291.13 KB [deleted]
dutch_auction.dutchauctioncontract.html 138.38 KB [deleted]
erc20_proxy.erc20proxycontract.html 180.44 KB [deleted]
erc20_token.erc20tokencontract.html 152.99 KB [deleted]
erc721_proxy.erc721proxycontract.html 180.76 KB [deleted]
erc721_token.erc721tokencontract.html 208.09 KB [deleted]
eth_balance_checker.ethbalancecheckercontract.html 63.85 KB [deleted]
exchange.exchangecontract.html 705.67 KB [deleted]
forwarder.forwardercontract.html 166.9 KB [deleted]
i_asset_proxy.iassetproxycontract.html 166.84 KB [deleted]
i_validator.ivalidatorcontract.html 63.74 KB [deleted]
i_wallet.iwalletcontract.html 62.67 KB [deleted]
multi_asset_proxy.multiassetproxycontract.html 218.05 KB [deleted]
order_validator.ordervalidatorcontract.html 137.28 KB [deleted]
weth9.weth9contract.html 201.33 KB [deleted]
zrx_token.zrxtokencontract.html 170.85 KB [deleted]
asset_proxy_owner.assetproxyownerevents.html 26.5 KB [deleted]
coordinator_registry.coordinatorregistryevents.html 12.82 KB [deleted]
dummy_erc20_token.dummyerc20tokenevents.html 13.73 KB [deleted]
dummy_erc721_token.dummyerc721tokenevents.html 15.06 KB [deleted]
erc20_proxy.erc20proxyevents.html 13.94 KB [deleted]
erc20_token.erc20tokenevents.html 13.55 KB [deleted]
erc721_proxy.erc721proxyevents.html 13.97 KB [deleted]
erc721_token.erc721tokenevents.html 14.83 KB [deleted]
exchange.exchangeevents.html 17.13 KB [deleted]
multi_asset_proxy.multiassetproxyevents.html 15.5 KB [deleted]
weth9.weth9events.html 15.51 KB [deleted]
zrx_token.zrxtokenevents.html 13.46 KB [deleted]
asset_proxy_owner.assetproxyownerassetproxyregistrationeventargs.html 17.28 KB [deleted]
asset_proxy_owner.assetproxyownerconfirmationeventargs.html 17.08 KB [deleted]
asset_proxy_owner.assetproxyownerconfirmationtimeseteventargs.html 17.23 KB [deleted]
asset_proxy_owner.assetproxyownerdepositeventargs.html 16.96 KB [deleted]
asset_proxy_owner.assetproxyownerexecutioneventargs.html 16.12 KB [deleted]
asset_proxy_owner.assetproxyownerexecutionfailureeventargs.html 16.17 KB [deleted]
asset_proxy_owner.assetproxyownerowneradditioneventargs.html 16.07 KB [deleted]
asset_proxy_owner.assetproxyownerownerremovaleventargs.html 16.07 KB [deleted]
asset_proxy_owner.assetproxyownerrequirementchangeeventargs.html 16.12 KB [deleted]
asset_proxy_owner.assetproxyownerrevocationeventargs.html 17.06 KB [deleted]
asset_proxy_owner.assetproxyownersubmissioneventargs.html 16.13 KB [deleted]
asset_proxy_owner.assetproxyownertimelockchangeeventargs.html 16.2 KB [deleted]
coordinator_registry.coordinatorregistrycoordinatorendpointseteventargs.html 14.7 KB [deleted]
dummy_erc20_token.dummyerc20tokenapprovaleventargs.html 15.38 KB [deleted]
dummy_erc20_token.dummyerc20tokentransfereventargs.html 15.34 KB [deleted]
dummy_erc721_token.dummyerc721tokenapprovaleventargs.html 15.72 KB [deleted]
dummy_erc721_token.dummyerc721tokenapprovalforalleventargs.html 15.77 KB [deleted]
dummy_erc721_token.dummyerc721tokentransfereventargs.html 15.67 KB [deleted]
erc20_proxy.erc20proxyauthorizedaddressaddedeventargs.html 14.45 KB [deleted]
erc20_proxy.erc20proxyauthorizedaddressremovedeventargs.html 14.47 KB [deleted]
erc20_token.erc20tokenapprovaleventargs.html 15.17 KB [deleted]
erc20_token.erc20tokentransfereventargs.html 15.12 KB [deleted]
erc721_proxy.erc721proxyauthorizedaddressaddedeventargs.html 14.49 KB [deleted]
erc721_proxy.erc721proxyauthorizedaddressremovedeventargs.html 14.5 KB [deleted]
erc721_token.erc721tokenapprovaleventargs.html 15.48 KB [deleted]
erc721_token.erc721tokenapprovalforalleventargs.html 15.53 KB [deleted]
erc721_token.erc721tokentransfereventargs.html 15.43 KB [deleted]
exchange.exchangeassetproxyregisteredeventargs.html 14.95 KB [deleted]
exchange.exchangecanceleventargs.html 18.8 KB [deleted]
exchange.exchangecanceluptoeventargs.html 15.9 KB [deleted]
exchange.exchangefilleventargs.html 23.7 KB [deleted]
exchange.exchangesignaturevalidatorapprovaleventargs.html 16.07 KB [deleted]
multi_asset_proxy.multiassetproxyassetproxyregisteredeventargs.html 14.93 KB [deleted]
multi_asset_proxy.multiassetproxyauthorizedaddressaddedeventargs.html 14.93 KB [deleted]
multi_asset_proxy.multiassetproxyauthorizedaddressremovedeventargs.html 14.95 KB [deleted]
weth9.weth9approvaleventargs.html 15.31 KB [deleted]
weth9.weth9depositeventargs.html 14.42 KB [deleted]
weth9.weth9transfereventargs.html 15.27 KB [deleted]
weth9.weth9withdrawaleventargs.html 14.45 KB [deleted]
zrx_token.zrxtokenapprovaleventargs.html 15.06 KB [deleted]
zrx_token.zrxtokentransfereventargs.html 15.02 KB [deleted]
asset_proxy_owner.html 21.01 KB [deleted]
coordinator.html 10.54 KB [deleted]
coordinator_registry.html 13.35 KB [deleted]
dummy_erc20_token.html 13.78 KB [deleted]
dummy_erc721_token.html 14.55 KB [deleted]
dutch_auction.html 10.57 KB [deleted]
erc20_proxy.html 13.76 KB [deleted]
erc20_token.html 13.54 KB [deleted]
erc721_proxy.html 13.8 KB [deleted]
erc721_token.html 14.26 KB [deleted]
eth_balance_checker.html 10.63 KB [deleted]
exchange.html 15.33 KB [deleted]
forwarder.html 10.52 KB [deleted]
i_asset_proxy.html 10.56 KB [deleted]
i_validator.html 10.54 KB [deleted]
i_wallet.html 10.51 KB [deleted]
multi_asset_proxy.html 14.81 KB [deleted]
order_validator.html 10.59 KB [deleted]
weth9.html 14.36 KB [deleted]
zrx_token.html 13.4 KB [deleted]
main.css 69.04 KB [deleted]
main.css.map 30.1 KB [deleted]
icons.png 9.26 KB [deleted]
[email protected] 27.09 KB [deleted]
widgets.png 480 bytes [deleted]
[email protected] 855 bytes [deleted]
main.js 148.53 KB [deleted]
search.js 517.35 KB [deleted]
erc1155_proxy.erc1155proxycontract.html 194.88 KB [deleted]
static_call_proxy.staticcallproxycontract.html 71.1 KB [deleted]
erc1155_proxy.erc1155proxyevents.html 13.73 KB [deleted]
erc1155_proxy.erc1155proxyauthorizedaddressaddedeventargs.html 14.25 KB [deleted]
erc1155_proxy.erc1155proxyauthorizedaddressremovedeventargs.html 14.27 KB [deleted]
erc1155_proxy.html 13.71 KB [deleted]
static_call_proxy.html 10.61 KB [deleted]

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 82.035% when pulling 37cc405 on fix/sol-compiler-bin-publish into 5ac7ff7 on development.

@dekz dekz mentioned this pull request Aug 10, 2019
4 tasks
@dekz dekz merged commit cb33189 into development Aug 13, 2019
@dekz dekz deleted the fix/sol-compiler-bin-publish branch August 13, 2019 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants