This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
WIP [Issue #1945] Downcase address comparison in private_key_wallet.ts in subproviders module #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen calling signTransactionAsync in the private key subprovider
…ionAsync in the private key subprovider
…matically added) and run 'yarn prettier' to format changes.
dekz
approved these changes
Jul 18, 2019
|
thanks so much @bstchow |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Downcase the initialized address of the private key wallet subprovider before comparing it with a signed transaction's origin address before comparing the two addresses to check for equality.
Resubmitted version of PR #1962 with proper Circle-CI and Code Coveralls configuration.
Testing instructions
Types of changes
Fixes defective behavior described in Issue #1945 as per direction from @dekz.
Checklist:
[WIP]if necessary.