This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Prune fields from EthBalanceChecker #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianny
changed the title
albrow
approved these changes
Jun 18, 2019
There was a problem hiding this comment.
Looks good to me, assuming CI passes. Maybe @fabioberger should take a look because I think he has more context.
|
@fabioberger , any idea why test-publish is failing here? 🤔 test-publish was also failing on other branches earlier so I am assuming it's not related to these changes. |
sjelfull
pushed a commit
to bakkenbaeck/0x-monorepo-1
that referenced
this pull request
Jun 21, 2019
Remove forbidden fields from EthBalanceChecker
fabioberger
pushed a commit
that referenced
this pull request
Aug 15, 2019
Remove forbidden fields from EthBalanceChecker
fabioberger
pushed a commit
that referenced
this pull request
Aug 15, 2019
Remove forbidden fields from EthBalanceChecker
fabioberger
pushed a commit
that referenced
this pull request
Aug 23, 2019
Remove forbidden fields from EthBalanceChecker
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unwanted fields and prettify. No bytecode or abi changes.
The extra fields in this artifact are currently causing other branches to break.
Testing instructions
I used a diff checker to compare bytecode diffs.
Run
yarn testwithincontract-artifactsto show that it passes required/forbidden properties checks.Types of changes
Checklist:
[WIP]if necessary.