This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
abi-gen should regenerate contract-wrappers if template files change #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianny
changed the title
xianny
changed the title
fabioberger
approved these changes
Jun 18, 2019
sjelfull
pushed a commit
to bakkenbaeck/0x-monorepo-1
that referenced
this pull request
Jun 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
abi-genonly checks the artifact file to determine if an existing generated wrapper is outdated. This PR adds a check for template files as well. Closes #1874Testing instructions
Added a unit test to
abi-gen.You can also try editing artifact/template files and running
yarn generate_contract_wrapperswithinabi-gen-wrappersto see if new wrappers get generated appropriately.Types of changes
Checklist:
[WIP]if necessary.