Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Update OrderValidator and create DevUtils contract #1835

Merged
merged 10 commits into from
Jun 1, 2019

Conversation

abandeali1
Copy link
Member

@abandeali1 abandeali1 commented May 27, 2019

Description

  • Renames OrderValidator to OrderValidationUtils for clarity
  • Adds signature checking to OrderValidationUtils
  • Refactors OrderValidationUtils to use logic from LibAssetData
  • Cosmetic changes to LibAssetData
  • Creates a top level DevUtils contract that will inherit all pure and view functions that are not in the core contracts

TODOs for a later PR:

  • Many of the DevUtils tests should be moved to the asset-proxy package
  • Add a remainingFillableAmount to getOrderAndTraderInfo
  • Move DevUtils out into its own package

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@coveralls
Copy link

coveralls commented May 27, 2019

Coverage Status

Coverage increased (+0.007%) to 83.679% when pulling 066f3bb on feat/contracts/dev-utils into cf04062 on development.

Copy link
Contributor

@dorothy-zbornak dorothy-zbornak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One bug, but looks good otherwise!

contracts/asset-proxy/contracts/src/libs/LibAssetData.sol Outdated Show resolved Hide resolved
@abandeali1 abandeali1 merged commit 4969441 into development Jun 1, 2019
@abandeali1 abandeali1 deleted the feat/contracts/dev-utils branch June 1, 2019 20:43
@dekz dekz added this to the v3 development milestone Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants