This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 465
Return array of FillResults in batch fill methods #1834
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abandeali1
changed the title
Feat/3.0/batch fill return values
Return array of FillResults in batch fill methods
May 26, 2019
abandeali1
changed the base branch from
3.0
to
feature/contracts/3.0/arbitrary-fees
May 26, 2019 18:33
merklejerk
approved these changes
May 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
dorothy-zbornak
approved these changes
May 28, 2019
hysz
approved these changes
May 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 looks good!
dorothy-zbornak
force-pushed
the
feat/3.0/batchFillReturnValues
branch
from
May 30, 2019 21:11
0cc518c
to
fc5393e
Compare
dorothy-zbornak
changed the base branch from
feature/contracts/3.0/arbitrary-fees
to
3.0
May 30, 2019 21:16
…e same memory location
dorothy-zbornak
force-pushed
the
feat/3.0/batchFillReturnValues
branch
from
May 30, 2019 21:27
fc5393e
to
e70b7f3
Compare
This was referenced Jan 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FillResults
for the batch fill variantsformatters
from thetest-utils
package and no longer passes in any nullassetData
fields into any function calls. Note that we had a task to remove the calldata optimizations inmatchOrders
and themarketFill
functions. For example, inmatchOrders
we have this rather than checking equality of theassetData
fields:I decided to leave these as is but clarify things a bit more in the comments, since this is actually cheaper than checking equality and still plays nicely with deduped calldata.
Testing instructions
Types of changes
Checklist:
[WIP]
if necessary.