This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Add transaction expirations and execution logs #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
contracts
@0x/json-schemas
@0x/order-utils
@0x/types
labels
abandeali1
force-pushed
the
feat/3.0/transactionExpirationsAndLogs
branch
from
3787d8d to
9143b24
Compare
abandeali1
force-pushed
the
feat/3.0/transactionExpirationsAndLogs
branch
from
9143b24 to
bfe6c7b
Compare
abandeali1
changed the base branch from
3.0
to
feature/contracts/3.0/arbitrary-fees
dorothy-zbornak
approved these changes
May 28, 2019
dorothy-zbornak
force-pushed
the
feat/3.0/transactionExpirationsAndLogs
branch
from
bfe6c7b to
21687c7
Compare
dorothy-zbornak
changed the base branch from
feature/contracts/3.0/arbitrary-fees
to
3.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TransactionExecutionevent that logs thetransactionHashexpirationTimeSecondsfield to transactionscoordinatorpackage still builds and passes tests, but the approvalsexpirationTimeSecondsis now probably redundant. This will be changes in a later PR after the 3.0 contracts are complete.Testing instructions
Types of changes
Checklist:
[WIP]if necessary.