This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
subproviders: Fix Trezor subprovider inefficiency #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…request it from the Trezor device for each request
dekz
approved these changes
May 23, 2019
Co-Authored-By: Jacob Evans <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cache the derived key info since it does not change and currently we request it from the Trezor device for each request.
Credit goes to @NoahZinsmeister who suggested this optimization: https://github.com/NoahZinsmeister/0x-monorepo/commit/d77ea80509a365acf941136c9ecc92be7bb2c7d1
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.