Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Incorrect decode in DutchAuctionWrapper #1815

Merged
merged 3 commits into from
May 15, 2019
Merged

Incorrect decode in DutchAuctionWrapper #1815

merged 3 commits into from
May 15, 2019

Conversation

dekz
Copy link
Member

@dekz dekz commented May 14, 2019

Description

Fixes #1814

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@dekz dekz requested a review from hysz May 14, 2019 18:19
@dekz dekz changed the title [WIP] Incorrect decode in DutchAuctionWrapper Incorrect decode in DutchAuctionWrapper May 14, 2019
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 84.089% when pulling b4b34e4 on bug/dutchAuctionDecode into 418d033 on development.

hysz
hysz approved these changes May 14, 2019
View reviewed changes
Copy link
Contributor

@hysz hysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dekz dekz merged commit c7f474a into development May 15, 2019
@dekz dekz deleted the bug/dutchAuctionDecode branch May 15, 2019 08:29
@snyk-bot snyk-bot mentioned this pull request Jun 18, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hysz hysz hysz approved these changes

Assignees
No one assigned
Labels
@0x/contract-wrappers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DutchAuctionWrapper is not decoding correctly
3 participants
@dekz @coveralls @hysz