This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
OrderWatcher Deposit/Withdraw events #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekz
changed the title
fabioberger
reviewed
May 10, 2019
| "pr": 1809 | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
The previous version hasn't been published yet. Please squish these into one.
fabioberger
approved these changes
May 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OrderWatcher seemed to intermittently handle (call the callback) deposit and withdraw events for WETH.
Before any orders were added the events were handled correctly, though after a WETH order was added it would cease to trigger a callback when a
WithdraworDepositevent occurred. Without handling these events a subscriber wouldn't be able to invalidate orders where the user withdrew all WETH funds.Testing instructions
Added repro test. Can be tested with Launch-Kit, creating an order, withdrawing WETH, query orders endpoint
Types of changes
Checklist:
[WIP]if necessary.