This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Add batchExecuteTransactions
#1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with missing function
abandeali1
changed the title
batchExecuteTransactionsbatchExecuteTransactions
dorothy-zbornak
approved these changes
Apr 27, 2019
|
|
||
| /// @dev Executes a batch of Exchange method calls in the context of signer(s). | ||
| /// @param transactions Array of 0x transactions containing salt, signerAddress, and data. | ||
| /// @param signatures Array of proofs that transactions have been signed by signer(s). |
There was a problem hiding this comment.
Missing @return natspec.
| /// @param transaction 0x transaction containing salt, signerAddress, and data. | ||
| /// @param signature Proof of signer transaction by signer. | ||
| /// @param signature Proof that transaction has been signed by signer. |
There was a problem hiding this comment.
Missing @return natspec.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bytesreturn value toexecuteTransaction. It will now return whatever data was returned by the underlying function callbatchExecuteTransactionsfunctionpreSignto be compatible withexecuteTransactionTesting instructions
Types of changes
Checklist:
[WIP]if necessary.