-
Notifications
You must be signed in to change notification settings - Fork 465
Conversation
packages/contract-wrappers/src/contract_wrappers/coordinator_wrapper.ts
Outdated
Show resolved
Hide resolved
packages/contract-wrappers/src/contract_wrappers/coordinator_wrapper.ts
Outdated
Show resolved
Hide resolved
packages/contract-wrappers/src/contract_wrappers/coordinator_wrapper.ts
Outdated
Show resolved
Hide resolved
packages/contract-wrappers/src/contract_wrappers/coordinator_wrapper.ts
Outdated
Show resolved
Hide resolved
packages/contract-wrappers/src/contract_wrappers/coordinator_wrapper.ts
Outdated
Show resolved
Hide resolved
@@ -39,6 +39,7 @@ | |||
}, | |||
"devDependencies": { | |||
"@0x/contracts-test-utils": "^3.1.2", | |||
"@0x/coordinator-server": "^0.0.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this is bringing in some old dependencies of contract-wrappers, might result in some strange behaviour.
packages/contract-wrappers/src/contract_wrappers/coordinator_wrapper.ts
Outdated
Show resolved
Hide resolved
packages/contract-wrappers/src/contract_wrappers/coordinator_wrapper.ts
Outdated
Show resolved
Hide resolved
packages/contract-wrappers/src/contract_wrappers/coordinator_wrapper.ts
Outdated
Show resolved
Hide resolved
packages/contract-wrappers/src/contract_wrappers/coordinator_wrapper.ts
Outdated
Show resolved
Hide resolved
I'd still like to write more tests for error cases to check the format of the errors, but apart from that I've implemented all the changes brought up. I changed everything to return |
d52815e
to
4e5f670
Compare
packages/contract-wrappers/src/contract_wrappers/coordinator_wrapper.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI tests pass
|
Description
Adds a wrapper for handling Coordinator transactions
Testing instructions
cd packages/contract-wrappers && yarn build && yarn test
Unit tests cover fills, soft cancels, hard cancels, and handling server errors.
Types of changes
Checklist:
[WIP]
if necessary.