This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
[3.0] Add LibExchangeRichErrorDecoder to exchange package #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorothy-zbornak
requested review from
abandeali1,
fabioberger,
hysz and
LogvinovLeon
as code owners
dorothy-zbornak
requested review from
feuGeneA
and removed request for
fabioberger and
LogvinovLeon
dorothy-zbornak
commented
Apr 24, 2019
| LibOrder.OrderStatus orderStatus, | ||
| bytes32 orderHash | ||
| bytes32 orderHash, | ||
| LibOrder.OrderStatus orderStatus |
There was a problem hiding this comment.
Swapped the order of these for consistency with other errors.
hysz
approved these changes
Apr 25, 2019
| ALREADY_EXECUTED | ||
| } | ||
|
|
||
| bytes4 internal constant SIGNATURE_ERROR_SELECTOR = |
There was a problem hiding this comment.
Note that these constant's will be evaluated everywhere they're referenced. May not matter for decoding, but if gas is important then something like this would be more efficient.
// bytes4(keccak256("SignatureError(uint8,bytes32,address,bytes)"))
bytes4 internal constant SIGNATURE_ERROR_SELECTOR = 0x7e5a2318;
There was a problem hiding this comment.
Oh, wow, I had no idea. That makes no sense to me. Definitely worth changing.
There was a problem hiding this comment.
@hysz does the new constantOptimizer optimizer flag change this? I haven't really looked into it, but I'm not sure what else it would do (this is already set to true in our compiler.json).
There was a problem hiding this comment.
Fixed in 8243a6f
dorothy-zbornak
changed the title
dorothy-zbornak
force-pushed
the
feature/3.0/contracts/exchange/rich-revert-decoder
branch
2 times, most recently
from
9fcb2ec to
8243a6f
Compare
abandeali1
approved these changes
Apr 30, 2019
Update coordinator tests for new tooling. Remove unecessary `chainId` parameter in `eip712_utils.createCoordinatorApprovalTypeData`
…abi-gen-wrappers` to use new domain schema and `Order` format.
…e rich revert errors. In `@0x/order-utils`: Change parameter order for `OrderStatusError`.
…RichErrors` into `MExchangeRichErrorTypes`. In `@0x/contracts-utils`: Pull types and constants from `MRichErrors` into `MRichErrorTypes`.
…rit from `@0x/contracts-exchange/.../MExchangeRichErrorTypes.sol`.
…s/src/libs/LibExchangeRichErrorDecoder`.
…ror_decoder` tests.
Run prettier/linter.
…revert selector constants.
…`0.5.8` docker image is released.
dorothy-zbornak
force-pushed
the
feature/3.0/contracts/exchange/rich-revert-decoder
branch
from
d3e8fb6 to
a587aa2
Compare
… to constantinople.
dorothy-zbornak
deleted the
feature/3.0/contracts/exchange/rich-revert-decoder
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary
This PR adds a
LibExchangeRichErrorDecodercontract to the@0x/contracts-exchangepackage. This contract exposes decoding (more like decomposing) functionality for ABI-encoded rich revert reasons (#1761).Notes
Exchangedoes not use this new contract (but it could). It's designed to be inherited by a TBD standalone contract, that will likely live in separate package.exchange-libsis not this contract's home for two reasons:exchange'sMExchangeRichErrorTypes. An alternative would be to moveMExchangeRichErrorTypesintoexchange-libs, but that seems like overkill since no other packages use that mixin.exchange-libsbecause they aren't really Exchange related. Rich reverts are defined and used within their contract package, so they might as well host their own decoder libraries.Testing instructions
You can find the new tests for this contract in
contracts/exchange/test/src/lib_exchange_rich_error_decoder.ts.Types of changes
Checklist:
[WIP]if necessary.