Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Fix OrderWatcher race-condition bug #1789

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Fix OrderWatcher race-condition bug #1789

merged 2 commits into from
Apr 24, 2019

Conversation

fabioberger
Copy link
Contributor

Description

Fixes the second race-condition identified in #1710.

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@coveralls
Copy link

coveralls commented Apr 23, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 84.764% when pulling cc3378b on fix/order-watcher-race-condition into 600b86d on development.

@fabioberger fabioberger merged commit 18acf50 into development Apr 24, 2019
@fabioberger fabioberger deleted the fix/order-watcher-race-condition branch April 24, 2019 21:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LogvinovLeon LogvinovLeon LogvinovLeon approved these changes

Assignees
No one assigned
Labels
@0x/order-watcher
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabioberger @coveralls @LogvinovLeon