Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Export utility methods and data from instant #1787

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Export utility methods and data from instant #1787

merged 1 commit into from
Apr 23, 2019

Conversation

fragosti
Copy link
Contributor

@fragosti fragosti commented Apr 23, 2019 •
edited
Loading

Description

Addressing PR feedback from the Wiki PR https://github.com/0xProject/wiki/pull/123

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

steveklebanoff
steveklebanoff approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@steveklebanoff steveklebanoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this -- I think this will help speed up instant integrations for ERC 721s quite a bit.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.764% when pulling 9c3fdd2 on feature/instant/utility-methods into 59ed5ae on development.

@fragosti fragosti merged commit 600b86d into development Apr 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steveklebanoff steveklebanoff steveklebanoff approved these changes

@BMillman19 BMillman19 Awaiting requested review from BMillman19

Assignees
No one assigned
Labels
@0x/instant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fragosti @coveralls @steveklebanoff