This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Fix/python-validations #1730
Closed
Fix/python-validations #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelhly
force-pushed
the
fix/python-validations
branch
2 times, most recently
from
93310c8 to
2d1f365
Compare
feuGeneA
suggested changes
Mar 25, 2019
There was a problem hiding this comment.
Let's not change the json schema in this PR. For one thing you'd also have to change the copy over in monorepo/packages/json-schemas (that's why the static-tests-python CI task is failing). But more broadly I think that change warrants a broader review/discussion with the 0x team. If this PR is just updating the sra-client regexes then I'm comfortable Approving it myself, without waiting to discuss with anyone else.
| "version": "1.0.1", | ||
| "changes": [ | ||
| { | ||
| "note": "Fix regix validation on numeric values" |
There was a problem hiding this comment.
Suggested change
| "note": "Fix regix validation on numeric values" | |
| "note": "Fix regex validation on numeric values" |
michaelhly
force-pushed
the
fix/python-validations
branch
2 times, most recently
from
64a25db to
0825184
Compare
michaelhly
requested review from
BMillman19,
fragosti and
steveklebanoff
as code owners
michaelhly
force-pushed
the
fix/python-validations
branch
from
0825184 to
4f58f7f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue described in #1727.
Testing instructions
run
./setup.py testin sra_client directory.Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
[WIP]if necessary.