Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Modify function visibilities in Coordinator contract #1729

Merged
merged 5 commits into from
Mar 25, 2019

Conversation

abandeali1
Copy link
Member

@abandeali1 abandeali1 commented Mar 24, 2019

Description

The following methods are now public:

  • decodeOrdersFromFillData
  • getCoordinatorApprovalHash
  • getTransactionHash

assertValidTransactionOrdersApproval is now internal. It didn't make sense for this to be public given that the passed in orders can differ from the orders in transaction.data, potentially leading to incorrect validation. It is always better to use assertValidCoordinatorApprovals.

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@coveralls
Copy link

coveralls commented Mar 24, 2019

Coverage Status

Coverage remained the same at 85.174% when pulling 17ff262 on feat/coordinator/functionVisibility into 4f25ff6 on development.

Copy link
Contributor

@dorothy-zbornak dorothy-zbornak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 👍

@abandeali1 abandeali1 force-pushed the feat/coordinator/functionVisibility branch from 20aedc2 to 17ff262 Compare March 25, 2019 17:12
@abandeali1 abandeali1 merged commit 7010b1a into development Mar 25, 2019
@abandeali1 abandeali1 deleted the feat/coordinator/functionVisibility branch June 1, 2019 20:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants