This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Fix error where object could be undefined given an approval event #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekz
changed the title
dekz
force-pushed
the
fix/order-watcher/1550
branch
from
d37a4ab to
f57f29e
Compare
fabioberger
approved these changes
Mar 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When tracking ApprovalForAll on ERC721, an untracked address (no orders added as a maker) could cause a lookup on undefined.
Fixed #1550
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.