Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Store blockTimestamp from NonFungible.com trade in seconds #1686

Closed
wants to merge 1 commit into from
Closed

Store blockTimestamp from NonFungible.com trade in seconds #1686

wants to merge 1 commit into from

Conversation

dafky2000
Copy link

Currently, NonFungible.com API sales are stored as milliseconds - Date.getTime() returns epoch time in milliseconds as opposed to seconds.

Description

Convert milliseconds to seconds before storage.

Types of changes

Bug fix

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

Currently, NonFungible.com API sales are stored as milliseconds - Date.getTime() returns epoch time in milliseconds as opposed to seconds.
@dafky2000 dafky2000 changed the title Save NonFungible.com NFT trade as seconds Store blockTimestamp from NonFungible.com trade in seconds Mar 8, 2019
@feuGeneA feuGeneA self-assigned this Mar 8, 2019
@albrow
Copy link
Contributor

albrow commented Mar 8, 2019

@dafky2000 why do you want to convert this to seconds? Pretty much all other timestamps in the raw schema use milliseconds.

@dafky2000
Copy link
Author

Sorry, this is re: An email from @feuGeneA - "nonfungible.com data timestamps inconsistent". Data pulled from the NF API is stored with a date in year 50587 in 0x's database. The initial data export I've provided had blockTimestamp as epoch in seconds but, the API returns a date string.

@feuGeneA
Copy link
Contributor

feuGeneA commented Mar 8, 2019

@dafky2000 thank you for taking such quick action on my email. I very much appreciate the submission.

I've handled this in another part of the code, in an outstanding PR I have.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants