This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Upgrade to websocket@^1.0.26 to fix broken tests #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et@^1.0.26. Update order-watcher's websocket dependency from ^1.0.25 (broken on some node architectures) to ^1.0.26.
abandeali1
approved these changes
Mar 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
order-watcherpackage was sporadically failing tests for me on clean installs of thedevelopmentbranch. It turns out my version ofyarn(1.13.0 [email protected]) kept pulling[email protected], which I discovered has a masking number calculation bug that is fixed in subsequent patches.I was able to get a corrected version installed and tests passing by upgrading
order-watcher's dependency fromwebsocket@^1.0.25towebsocket@^1.0.26AND removing the[email protected]entry in the rootyarn.lockfile (there are two others pointing to1.0.26already).So far I've been the only one who could replicate this issue, probably because I'm on a rolling release distro.
I don't foresee this minor change having any noticeable impact on working copies.
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.