Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

Upgrade contracts to Solidity 0.5.5 #1682

Merged
merged 5 commits into from
Mar 12, 2019

Conversation

abandeali1
Copy link
Member

@abandeali1 abandeali1 commented Mar 7, 2019

Description

  • Upgrades most contracts to Solidity 0.5.5 (except those that will not be redeployed)
  • Makes the minimum necessary changes to get the contracts to compile and pass tests with the new Solidity version
  • Uses new optimizer settings (saves ~3.5k gas / fill!)
  • Updates ganache-cli and solcjs versions
  • No longer re-export external contract dependencies within each package (this was causing incompatibility between packages)
  • Note: this still compiles with evmVersion: 'byzantium'. It appears that compiling with 0.5.5 introduces some new opcodes that cause the contracts to not deploy. Updating ganache-cli did not fix the issue (even though it supports Constantinople). This should be fixed in a separate PR.

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@abandeali1 abandeali1 force-pushed the feat/contracts/solidity0.5.5 branch from 1615f54 to 2f7dd17 Compare March 7, 2019 23:18
Copy link
Contributor

@merklejerk merklejerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't build for me because contracts/erc20/tsconfig.json still references ReentrantERC20Token.json.

@coveralls
Copy link

coveralls commented Mar 8, 2019

Coverage Status

Coverage increased (+0.02%) to 85.167% when pulling 22af796 on feat/contracts/solidity0.5.5 into 9e03e1c on development.

@abandeali1 abandeali1 force-pushed the feat/contracts/solidity0.5.5 branch from 6b67a0a to 4555310 Compare March 8, 2019 01:40
Copy link
Contributor

@hysz hysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@merklejerk
Copy link
Contributor

exchange-forwarder is still at 0.4.24. Is this intentional?

@abandeali1
Copy link
Member Author

@merklejerk that is intentional, but we'll make the change when the Forwarder is ready to be updated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants