This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abandeali1
force-pushed
the
feat/contracts/solidity0.5.5
branch
from
March 7, 2019 23:18
1615f54
to
2f7dd17
Compare
merklejerk
suggested changes
Mar 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't build for me because contracts/erc20/tsconfig.json
still references ReentrantERC20Token.json
.
abandeali1
force-pushed
the
feat/contracts/solidity0.5.5
branch
from
March 8, 2019 01:40
6b67a0a
to
4555310
Compare
abandeali1
force-pushed
the
feat/contracts/solidity0.5.5
branch
from
March 8, 2019 03:36
4555310
to
22af796
Compare
4 tasks
hysz
approved these changes
Mar 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
|
@merklejerk that is intentional, but we'll make the change when the Forwarder is ready to be updated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ganache-cli
andsolcjs
versionsevmVersion: 'byzantium'
. It appears that compiling with 0.5.5 introduces some new opcodes that cause the contracts to not deploy. Updatingganache-cli
did not fix the issue (even though it supports Constantinople). This should be fixed in a separate PR.Testing instructions
Types of changes
Checklist:
[WIP]
if necessary.