This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Coordinator Registry #1675
Merged
Coordinator Registry #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hysz
force-pushed
the
feature/contracts/TECRegistry-2
branch
from
47c8e04 to
6675efc
Compare
hysz
force-pushed
the
feature/contracts/TECRegistry-2
branch
3 times, most recently
from
4f8d807 to
382e046
Compare
abandeali1
approved these changes
Mar 7, 2019
|
|
||
| /// @dev Gets the endpoint for a Coordinator. | ||
| /// @param coordinatorOperator operator of the Coordinator endpoint. | ||
| function getCoordinatorEndpoint(address coordinatorOperator) external view returns (string memory coordinatorEndpoint) { |
There was a problem hiding this comment.
Can we put the modifiers on separate lines?
|
|
||
| /// @dev Gets the endpoint for a Coordinator. | ||
| /// @param coordinatorOperator operator of the Coordinator endpoint. | ||
| function getCoordinatorEndpoint(address coordinatorOperator) external view returns (string memory coordinatorEndpoint); |
hysz
force-pushed
the
feature/contracts/TECRegistry-2
branch
2 times, most recently
from
e3f01f0 to
ac4ad09
Compare
fabioberger
approved these changes
Mar 7, 2019
contracts/coordinator/CHANGELOG.json
Outdated
| "pr": 1675 | ||
| } | ||
| ] | ||
| }, |
There was a problem hiding this comment.
It looks like we never published 0.0.1, let's roll these into one CHANGELOG entry.
hysz
force-pushed
the
feature/contracts/TECRegistry-2
branch
from
ac4ad09 to
bd86b59
Compare
hysz
force-pushed
the
feature/contracts/TECRegistry-2
branch
from
bd86b59 to
93568f6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A basic Coordinator registry contract that allows a Coordinator operator to record the endpoint of their Coordinator, to be queried by the public.
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.