This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Add tx.origin to TEC approvals #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abandeali1
force-pushed
the
feat/contracts/tec-txorigin-check
branch
from
80c7db2 to
b1d86a7
Compare
hysz
suggested changes
Mar 7, 2019
| let arrayContentsStart := add(addressArray, 32) | ||
|
|
||
| // Loop through array | ||
| for {let i:= 0} lt(i, arrayByteLen) {i := add(i, 32)} { |
There was a problem hiding this comment.
Should save some additional gas with this:
for {let i := arrayContentsStart} lt(i, arrayContentsEnd) {i := add(i, 32)} {
let arrayElement := mload(i)
}
One less add per iteration.
| let arrayContentsStart := add(addressArray, 32) | ||
|
|
||
| // Loop through array | ||
| for {let i:= 0} lt(i, arrayByteLen) {i := add(i, 32)} { |
| // Verify that Ethereum tx signer is the same as the approved txOrigin | ||
| require( | ||
| tx.origin == txOrigin, | ||
| "INVALID_SENDER" |
There was a problem hiding this comment.
Could be good to use INVALID_ORIGIN. Similar instances of INVALID_SENDER refer to an invalid msg.sender
./exchange-libs/contracts/src/LibExchangeErrors.sol: string constant internal INVALID_SENDER = "INVALID_SENDER"; // Invalid `msg.sender`.
hysz
approved these changes
Mar 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
txOriginfield to the Coordinator approval message. The transaction must be executed by this address. This prevent's a user's transaction from being front-runned when it is intended to be used in conjunction with external smart contract calls.Testing instructions
Types of changes
Checklist:
[WIP]if necessary.